Skip to content

Replace OutputSpendStatus with SpendInfo#83

Closed
Sosthene00 wants to merge 1 commit intomasterfrom
replace_spend_status_info
Closed

Replace OutputSpendStatus with SpendInfo#83
Sosthene00 wants to merge 1 commit intomasterfrom
replace_spend_status_info

Conversation

@Sosthene00
Copy link
Collaborator

@Sosthene00 Sosthene00 commented Feb 6, 2026

Pretty straightforward, I replaced the enum OutputSpendStatus with a new SpendInfo:

  • The enum was making us lose information when transaction passed from Spent to Mined
  • It doesn't transcribe as well in a sql format (see Wallet sqlite dana#272)

@Sosthene00 Sosthene00 force-pushed the replace_spend_status_info branch from 6aaa512 to 1c8ded0 Compare February 11, 2026 21:24
@cygnet3
Copy link
Owner

cygnet3 commented Feb 12, 2026

Made a PR for this on the Dana side to support this: cygnet3/dana#292

cygnet3
cygnet3 reviewed Feb 12, 2026
View reviewed changes
@Sosthene00 Sosthene00 force-pushed the replace_spend_status_info branch 2 times, most recently from 15401b2 to 63856a9 Compare February 16, 2026 07:38
@Sosthene00 Sosthene00 changed the base branch from dev to master February 16, 2026 07:48
@cygnet3 cygnet3 force-pushed the replace_spend_status_info branch 2 times, most recently from 40210e8 to 396fd6f Compare February 18, 2026 00:11
@Sosthene00 Sosthene00 force-pushed the replace_spend_status_info branch from 396fd6f to 0b936de Compare February 18, 2026 10:29
@Sosthene00
Copy link
Collaborator Author

Sosthene00 commented Feb 20, 2026

#102 makes it without object, closing

@Sosthene00 Sosthene00 closed this Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cygnet3 cygnet3 cygnet3 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sosthene00 @cygnet3